benwbrum / fromthepage / 28663575666

74%

push

github

Fix AI tab hidden when most recent AI transcription has error status (#5648)

* Initial plan

* Fix AI tab visibility: show tab when any finished AI transcription exists

Previously, the AI tab was hidden if the most recent AI transcription had
an error status, even if older successful (finished) drafts existed.

Fix the condition in _page_tabs.html.slim and the guard in
display_controller#ai_text to check for any finished AI transcription
rather than only the most recent one.

Closes #5647

* Fix ai_transcription association to return most recent finished transcription

Scope the has_one :ai_transcription relation on Page to only finished
records, ordered by created_at desc. This ensures all callers (tab
visibility, controller guard, IIIF export, model methods) consistently
see the most recent *successful* AI transcription rather than the most
recent one regardless of status.

Reverts the previous UI-level workarounds in _page_tabs.html.slim and
display_controller.rb in favour of this model-level fix.

Closes #5647

* Simplify redundant status_finished? checks after model-level fix

Now that has_one :ai_transcription is scoped to finished records,
the status_finished? guard checks are redundant. Simplify to presence
checks throughout.

* Fix AI transcription lookup regression

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

2687 of 4241 branches covered (63.36%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

10898 of 14239 relevant lines covered (76.54%)

195.98 hits per line