kibertoad / layered-loader / 28662275514

98%

push

github

Apply remaining #418 performance optimizations on top of #417 (#419)

* Apply performance optimizations from #418 on top of #417

The bug fixes originally bundled in #418 (falsy value caching in
InMemoryCache/InMemoryGroupCache getMany, and reads no longer inserting
empty groups into the LRU) already landed via #417, so only the
performance and code-quality changes remain:

- AbstractFlatCache/AbstractGroupCache: resolve the cache key once and
  reuse it across getInMemoryOnly/getAsyncOnly/get instead of resolving
  it multiple times per call
- getMany merge appends async results into the in-memory result array in
  place (it is always freshly allocated) rather than spreading into a new
  array
- Loader/GroupLoader: build cache entries with an explicit loop, merge
  cached and loaded values with concat (cachedValues may be owned by a
  user-implemented async cache), and hoist the dataSource local
- AbstractRedisCache: precompute keyPrefix; RedisGroupCache: precompute
  the group index prefix and the per-group entry prefix
- unique(): early return for arrays of 0-1 elements

Regression tests for the falsy-caching path at the loader level and for
the unique() early return are included.

* Update toad-cache

406 of 424 branches covered (95.75%)

Branch coverage included in aggregate %.

50 of 50 new or added lines in 7 files covered. (100.0%)

745 of 745 relevant lines covered (100.0%)

123.11 hits per line