archetech / archon / 28659662172

92%

push

github

fix(rust-gatekeeper): return 400 invalidDid for a malformed-CID DID (#687)

* fix(rust-gatekeeper): return 400 invalidDid for a malformed-CID DID (#686)

On /1.0/identifiers, a syntactically-`did:` DID with a malformed CID suffix
(e.g. `did:cid:xyz`) returned 404 notFound in Rust but 400 invalidDid in the
TS reference, because Rust classified invalidDid only via a `did:` prefix check
while TS validates the CID (isValidDID -> isValidCID).

Add `is_valid_did` (proofs.rs) mirroring the TS rule — `did:` prefix, >=3
`:`-separated segments, final segment parses as a CID (via the `cid` crate) —
and use it in `classify_conformant_error` instead of the prefix check. A
malformed-CID DID now returns 400 invalidDid, matching TS.

Tests: unit tests for `is_valid_did` and an added malformed-CID case in the
classifier test; parity fixture `conformant-resolve-invalid-cid` (both impls now
agree on 400). Full lib suite green (26), clippy clean.

Closes #686.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(rust-gatekeeper): allocation-free is_valid_did (Copilot review)

Use iterators (split(':').count() + rsplit(':').next()) instead of collecting a
Vec just to check the segment count and read the last segment. No behavior
change; slightly more idiomatic. clippy + is_valid_did/classifier tests green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2816 of 3323 branches covered (84.74%)

Branch coverage included in aggregate %.

5851 of 6142 relevant lines covered (95.26%)

882.15 hits per line