ponder-lab / Hybridize-Functions-Refactoring / #2297

80%

main: 80%

push

github

Exempt Keras lazy-`build` weight creation from the side-effect precondition (#723)

Since Ariadne 0.52.12 models the lazy-`build` protocol in the `__call__` trampoline, a container `call` invoking a sublayer sees the sublayer's `build`-time writes—the `add_weight` stores and the `built` flag, on an object created in the container's `__init__`—in its mod set, and `HAS_PYTHON_SIDE_EFFECTS` blocks the container. Those writes are the once-only, framework-sanctioned Keras initialization that `tf.function` supports on the first trace, not the recurring Python side-effects the precondition guards against.

`Function.subtractBuildProtocolContributions` removes, from the analyzed function's transitive mod set, the contributions of reachable `build`-method nodes (worklist walk over call-graph successors; a `build` under analysis never masks itself). Subtracting a `build` node's transitive mod also drops its `add_weight`-summary and `built`-flag stores, restoring the pre-0.52.12 status quo in which `build` bodies were never reached.

`testPythonSideEffects66` pins the exemption (container over a lazily-built sublayer: no side-effects; fails without the fix) and `testPythonSideEffects67` pins the boundary (a sublayer mutating its own attribute in `call`, mirroring NLPGNN's `cached_result`: still a side-effect).

Closes #720.


Claude-Session: https://claude.ai/code/session_01S1U9TQRo3Wmhfu86DRcBNW

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

25 of 25 new or added lines in 1 file covered. (100.0%)

1689 of 2124 relevant lines covered (79.52%)

0.8 hits per line