kubeovn / kube-ovn / 28634787952

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix: improve BGP BFD metrics, logging, type safety and peer state check (#6941)





* refactor(speaker): improve BFD logging, type safety and peer state monitoring

- BFDDetectionMultiplier: uint32 → uint8 with pflag.Uint8 (RFC 5880 §6.8.1)
- Add ms→μs overflow validation (MaxUint32/1000 boundary)
- BFD stats: log only on errors (Warningf) or recovery (Infof)
- BFD peer state: diff caching, log only on state change
- Add watchPeerState() for BGP peer state change monitoring with BFD state
- Move newBFDPeerConfig() to bfd.go with explicit uint32 cast

* feat(speaker): add BGP/BFD Prometheus metrics and delta-based BFD error logging

Expose per-peer BGP session state/flap/queue/message counters and BFD
server/peer statistics as gauges on the existing speaker metrics endpoint,
following Cilium's gauge-based design for cumulative counters so PromQL
rate()/increase() can derive per-interval deltas. Metrics are registered to
the controller-runtime registry and collected each reconcile cycle, gated by
--enable-metrics (and --enable-bfd for BFD).

Also switch BFD server error logging from an absolute (>0) check to
delta-based detection: warn only when error counters increase since the last
sample, handle counter reset/rollover, and include the per-counter delta in
the warning to avoid permanent warnings from non-resetting cumulative counters.

- Wrap ListPeer/ListBfdPeer in context.WithTimeout(3s). The reconcile loop
  runs serially via wait.Until, so an unbounded gRPC call to a hung GoBGP
  server would block the entire loop (route sync included), not just metrics.
- Replace the per-cycle Reset() of every per-peer series with delta-based
  deletion driven by lastBGPPeers/lastBFDPeers. Reset() exposed a brief empty
  window to a concurrent Prometheus scrape (metric flapping); deleting only
  the series of peers that disappeared removes that window.
- On ListPeer error, keep the previous series instead of blanking them.
---------

Signed-off-by: zbb88888 <jmd... (continued)

Coverage Stats

85 of 267 new or added lines in 4 files covered. (31.84%)

6 existing lines in 2 files now uncovered.

16632 of 60688 relevant lines covered (27.41%)

0.32 hits per line