archetech / archon / 28631630552

92%

main: 92%

Pull #685

github

fix(rust-gatekeeper): address Copilot review on conformant error classification

- Preserve specific diagnostics (#1/#2): resolve_local_doc_async's typed bails
  no longer collapse to a generic message. not_found()/invalid_operation()
  attach the original message ("Invalid operation: proof" vs ": previd",
  "first operation must be create", etc.) as .context() on the typed
  ResolveError, so logs stay actionable while the type still drives
  classification.
- Close the validation-error leak (#3): verify-stack data errors that lacked
  the "Invalid operation" prefix (e.g. a malformed base64url proof value in
  verify_sig) were misclassified as internalError (500). classify_conformant_error
  now inspects the whole cause chain for a ResolveError OR the "Invalid operation"
  convention, and verify_sig wraps its caller-data parses with that context.
  Dropped tag_verify_error (subsumed). Validation failures now 404 as required.
- Log on 500 (#4): resolve_conformant now logs the underlying error (did + full
  cause chain) when it classifies as internalError, matching the TS reference and
  the §2.6 "SHOULD be logged" clause; the client still only sees "internalError".

Classifier unit test extended to cover the "Invalid operation"-convention path.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2816 of 3323 branches covered (84.74%)

Branch coverage included in aggregate %.

5851 of 6142 relevant lines covered (95.26%)

882.15 hits per line