thanos / beancount_ex / 505be227e77c141889804a61892b4068ae7abef8-PR-63

96%

main: 96%

Build Type

Pull #63

github

Committed by thanos

Commit Message

This branch reunifies the native engine into `beancount_ex`, removes the Datalog/native-BQL
stack, and introduces the release's headline feature: an Ecto/SQLite storage layer
(`Beancount.Repo`, `Beancount.Storage`, `Beancount.Queries`, 19 schemas).

**The mature parts of the codebase are in excellent shape.** The parser, booking engine,
directive sorting, renderer, compare harness, and golden/property test infrastructure are
well-tested (97.2 % coverage), Decimal-safe, dialyzer-clean, and largely match their
documentation. CLI temp-file handling, error propagation, and concurrency discipline are
sound.

**The new storage layer is not release-ready.** Empirical testing found five verified
data-fidelity bugs in the store → load → render path: `custom` directives crash
`export_file/1`, price annotations crash rendering after load, option values lose their
type, `pushtag`/`poptag` ordering is destroyed on load (contradicting the module docs),
and non-string metadata values are silently stringified. The storage test suite is
happy-path only and in one case *asserts the buggy behavior as correct*. Separately, the
native engine has one Critical gap (`include` files are existence-checked but never
loaded) and the parser crashes on invalid calendar dates.

Pull Request Pull Request #63: V0.6.0/ecto storage native queries reunify

Coverage Stats

561 of 606 new or added lines in 20 files covered. (92.57%)

2 existing lines in 1 file now uncovered.

1880 of 1967 relevant lines covered (95.58%)

165.08 hits per line