pulibrary / orangelight / 3e0d1581-4fc3-4238-92a8-8fa9759c63c1
96%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 229
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 95.692%. Remained the same
3e0d1581-4fc3-4238-92a8-8fa9759c63c1

push

circleci

web-flow 
Migrate requests form_spec from VCR to WebMock stubs (#5999)

* Migrate requests form_spec from VCR to WebMock stubs

Remove the form_features cassette and stub every HTTP request explicitly
with the existing helpers (stub_single_holding_location,
stub_availability_by_holding_id, stub_catalog_raw), so unstubbed requests
now fail loudly instead of being silently served by VCR.

- Extract 76 fixtures from the cassette's recorded response bodies
- Update 13 existing fixtures that had drifted from the recorded data
  (delivery locations and item barcodes no longer matched, which the
  cassette's playback precedence had been masking)
- Stub two bibdata availability endpoints the cassette served as errors
  (a 400 for 99125452799106421 and a 504 for the bad-mfhd case) inline,
  since the helpers only produce 200s
- Replace an Illiad transaction stub whose body matcher was copied from a
  different bib and never matched; the cassette's 401 response had been
  masking it, so stub the 401 the tests actually exercised
- Delete spec/cassettes/form_features.yml (only form_spec referenced it)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* Strip Solr-internal fields from extracted raw fixtures

The fixtures extracted from the form_features cassette were raw Solr
documents that still contained _version_ and timestamp. pulsearch:solr:index
posts everything under spec/fixtures/raw to Solr, and a positive _version_
triggers optimistic concurrency, so CI failed with 409 version conflicts.
Remove both fields, matching the pre-existing fixtures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* Restore search index fields to raw fixtures added from the cassette

pulsearch:solr:index posts spec/fixtures/alma before spec/fixtures/raw, so
a raw fixture sharing a doc id with an alma fixture overwrites it in Solr.
The new ... (continued)

6353 of 6639 relevant lines covered (95.69%)

1424.92 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3e0d1581-4fc3-4238-92a8-8fa9759c63c1.1 229
95.69
Source Files on build 3e0d1581-4fc3-4238-92a8-8fa9759c63c1