trixi-framework / Trixi.jl / 28599869479

97%

Build Type

push

github

Committed by web-flow

Commit Message

Add positivity-limiter to the `AMRCallback` (#2396)

* add positivity limiter to the amr callback

* remove duplicate limiter! argument

* Update src/callbacks_step/amr.jl

Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>

* Implement synchronized shifting for child elements

* Implement synchronized shifting for child elements

* Fix increase of `element_id`

* Revise implementation with mean value of parent element

* Add 1D and 3D

* Remove if and use dispatching

* Decrease theta by eps()

* Implement first suggestions

* Compute mean within `limiter !== nothing`

* Add suggested comment

* Restructure call of limiter for refined elements

* Implement suggestions

* Implement thread parallel version; Add timer

* Remove `@assert`

* Add function for coarsened elements

* Fix dimension

* Add auxiliary functions to compute new elements ids

* Fix function name

* Use `compute_u_mean`; Update docstring

* Use `compute_u_mean` in limiter after coarsening

* Rename function

* Implement suggestions

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Update src/callbacks_stage/positivity_zhang_shu_dg1d.jl

* Apply suggestions from code review

* Update src/callbacks_stage/positivity_zhang_shu_dg2d.jl

* Update src/callbacks_stage/positivity_zhang_shu_dg1d.jl

* Update src/callbacks_stage/positivity_zhang_shu_dg1d.jl

* Apply suggestions from code review

* Rename for-variables; Remove comments

* Remove codes as suggested

* add comment for amr positivity-limiting

* Apply limiter after refinement/coarsening for T8codeMesh (#50)

* Apply limiter after refinement/coarsening with T8codeMesh

* Implement suggestions

* doc

* Add simple tests

* Update test/test_unit.jl

* Update src/callbacks_step/amr.jl

* Remove dispatching

* Use Array{T, 2} instead of Matrix{T}

* Add timer to computation of parent's mean value

* Fix tests (Set `periodic... (continued)

Coverage Stats

229 of 235 new or added lines in 8 files covered. (97.45%)

4 existing lines in 1 file now uncovered.

49429 of 51050 relevant lines covered (96.82%)

41757207.06 hits per line