Qiskit / qiskit / 28599829984

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix OverflowError in QuantumCircuit.for_loop for negative integers in list indexset   (#16432) (#16525)

* Fix OverflowError in for_loop for negative integers

* trigger ci

* trigger ci

* Add QPY compatibility test for for_loop with negative indexset

* Merge main, fix linting, and refine QPY compatibility tests

* Fix C API: revert CLoopElements to usize, cast internally

* Fix C API type, QPY compat gate, and add release note

- Fix CLoopElements.elements type from *const usize to *const isize.
  The cast was a sign that the exposed C API type was wrong; using isize
  (intptr_t in C) is correct for signed loop indices.
- Update QPY compat test to re-enable for_loop_negative.qpy generation
  for versions >= 2.5.0 where the fix lands.
- Add release note for the bug fix.

* Fix C test: use intptr_t for QkLoopElements element comparisons

Update the C test to compare loop elements as intptr_t (the C
equivalent of isize) instead of size_t, matching the corrected
QkLoopElements.elements field type.

* Revert premature QPY version gate for 2.5.0

The fix hasn't made it to a 2.5.0 release yet (the CI runs against 2.5.0rc1
which currently lacks this fix). Leave the gate for 1.x only. The higher-end
gate should be added when this fix is actually backported.

* Reword release note

* Fix types in C test

* Re-enable QPY tests after 2.5.0

* Revert incorrect C-type fix

* Fix QPY reverse-version compatibility tests

---------


(cherry picked from commit dc24fc3ac)

Co-authored-by: Ebrahim Eldesoky <at264939@gmail.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

17 existing lines in 3 files now uncovered.

112775 of 128684 relevant lines covered (87.64%)

999281.72 hits per line