clay / claycli / 28601919018

87%

master: 87%

push

github

🍕 Harden browser-compat stubs + add kiln-edit bundle smoke test

Prevent the class of edit-mode crash where a Node-builtin browser stub is
import-unsafe (throws at module evaluation) — the family the safe-buffer #253
crash belongs to — and add a real-bundle smoke test so these regress in CI
instead of in an editor's console.

#1 CI boot-smoke test (browser-compat.bundle.test.js)
- Runs the real kiln-edit plugin pipeline (browser-compat + node-resolve +
  commonjs) over the libraries that have broken before (safe-buffer,
  create-hash) and evaluates the emitted bundle in a Buffer-less VM. A
  stub-shape regression now fails CI.

#2 Prefer real browser globals over bespoke shims, at zero bundle cost
- Codify the stub import-safety invariant and add a shared preferGlobal()
  helper (single source of truth for "use globalThis.X, else minimal shim").
- buffer/node-fetch already did this; apply it to url (globalThis.URL /
  URLSearchParams). No heavyweight polyfills added.

Fixes surfaced by the smoke test
- string_decoder was an empty stub, but cipher-base (crypto-browserify ->
  create-hash/createHmac) does `new StringDecoder(enc)` inside .digest(enc):
  an empty stub throws "StringDecoder is not a constructor" the instant a
  hash/HMAC is stringified in the browser. Promoted to a minimal rich stub
  whose StringDecoder delegates to Buffer.toString(encoding).
- node:-prefixed rich builtins (node:buffer, node:stream, ...) were listed in
  SIMPLE_STUBS, forcing them to empty stubs and re-opening the subclass-at-eval
  crash. resolveId already normalizes the node: prefix, so the explicit entries
  are removed; rich node: forms now route to the rich stub.

Adds safe-buffer + create-hash as devDependencies (smoke-test fixtures only).

Co-authored-by: Cursor <cursoragent@cursor.com>

758 of 935 branches covered (81.07%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

1622 of 1789 relevant lines covered (90.67%)

12.69 hits per line