source-academy / py-slang / 28601234788

78%

Build Type

push

github

Committed by web-flow

Commit Message

feat: implement nonlocal keyword and scope conflict validators (#182)

* fix: buffer stdout and flush as a single sendOutput to fix multiple prints

When print() was called multiple times, only the first line appeared.
Root cause: each sendOutput call sends a separate postMessage to the
host, where the frontend's redux-saga handleStdout task processes one
message per iteration. The STATUS STOPPED message arriving after all
output would trigger task cancellation, but the saga scheduler could
cancel handleStdout between iterations, dropping remaining messages.

Fix: collect all stdout writes into a local buffer during evaluation and
flush the entire buffer as a single sendOutput call after collectSnapshots
completes. One message = one handleStdout iteration = no race condition.
The flush also runs in the catch path so partial output before an error
is still shown.

* fix: clear buffer after flush and add tests for createBufferedOutputStream

- Reset buffer to "" after sendOutput so double-flush (try path + catch
  path when sendSnapshots throws) never duplicates output
- Use strict !== "" check instead of truthy to match the guard condition
  unambiguously
- Add streams.test.ts with 3 unit tests covering: single-flush batching,
  no-op on empty buffer, and idempotent double-flush

Addresses Gemini review comment on PR 176 and restores coveralls coverage.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: implement nonlocal keyword and scope conflict validators (#177-#181)

Closes #177: nonlocal keyword now works at runtime — Closure gains
nonlocalVariables set; FunctionDef handler populates it via
scanForNonlocalDeclarations; Variable reads and ASSIGNMENT writes are
routed through pyGetNonlocalVariable/pySetNonlocalVariable which walk
the enclosing function env chain (stopping before the module scope).
The NonLocal statement is registered as a no-op handler so it no longer
crashes the interpreter.

Closes #178: resolver raises SyntaxErr... (continued)

Coverage Stats

2386 of 3389 branches covered (70.4%)

Branch coverage included in aggregate %.

259 of 272 new or added lines in 8 files covered. (95.22%)

3 existing lines in 1 file now uncovered.

5835 of 7269 relevant lines covered (80.27%)

13861.26 hits per line