tarantool / tarantool / 28599769216

88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

memtx: fix MVCC replace rollback after result tuple preparing error

After a successful memtx replace, preparing the old tuple for return may
fail, for example while applying a space upgrade function. The old code
handled this by issuing a compensating replace from the same statement.

This is unsafe with memtx MVCC, because the compensating replace goes
through the regular MVCC bookkeeping again and reuses the same txn_stmt,
which may already have attached stories from the original replace.

Register statement rollback information right after the physical replace
succeeds and let the regular statement rollback path undo the change on
error.

Closes #12608

NO_DOC=bugfix
NO_TEST=ee
NO_CHANGELOG=ee

Coverage Stats

70910 of 119058 branches covered (59.56%)

10 of 10 new or added lines in 1 file covered. (100.0%)

18 existing lines in 13 files now uncovered.

106446 of 121313 relevant lines covered (87.74%)

1408838.8 hits per line