Qiskit / qiskit / 28593126809
88%
main: 88%

LAST BUILD BRANCH: truncate_label
DEFAULT BRANCH: main
Ran
Jobs 1
Files 951
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.653% (-0.01%) from 87.665%
28593126809

push

github

web-flow 
Fix OverflowError in QuantumCircuit.for_loop for negative integers in list indexset   (#16432)

* Fix OverflowError in for_loop for negative integers

* trigger ci

* trigger ci

* Add QPY compatibility test for for_loop with negative indexset

* Merge main, fix linting, and refine QPY compatibility tests

* Fix C API: revert CLoopElements to usize, cast internally

* Fix C API type, QPY compat gate, and add release note

- Fix CLoopElements.elements type from *const usize to *const isize.
  The cast was a sign that the exposed C API type was wrong; using isize
  (intptr_t in C) is correct for signed loop indices.
- Update QPY compat test to re-enable for_loop_negative.qpy generation
  for versions >= 2.5.0 where the fix lands.
- Add release note for the bug fix.

* Fix C test: use intptr_t for QkLoopElements element comparisons

Update the C test to compare loop elements as intptr_t (the C
equivalent of isize) instead of size_t, matching the corrected
QkLoopElements.elements field type.

* Revert premature QPY version gate for 2.5.0

The fix hasn't made it to a 2.5.0 release yet (the CI runs against 2.5.0rc1
which currently lacks this fix). Leave the gate for 1.x only. The higher-end
gate should be added when this fix is actually backported.

* Reword release note

* Fix types in C test

* Re-enable QPY tests after 2.5.0

* Revert incorrect C-type fix

* Fix QPY reverse-version compatibility tests

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

112847 of 128743 relevant lines covered (87.65%)

997207.38 hits per line

Coverage Regressions

Lines Coverage ∆ File
10
74.8
 -0.41% crates/circuit/src/parameter/symbol_expr.rs
6
97.15
 -0.48% crates/qasm2/src/parse.rs
4
92.54
 0.26% crates/qasm2/src/lex.rs
Jobs
ID Job ID Ran Files Coverage
1 28593126809.1 951
87.65
 GitHub Action Run
Source Files on build 28593126809