28590072900
90%

Ran 02 Jul 2026 12:37PM UTC

Jobs 1

Files 177

Run time 2min

Badge

Embed ▾

Committed 02 Jul 2026 12:29PM UTC coverage: 91.716% (-0.009%) from 91.725%

Build # 28590072900

Build Type

push

github

Committed by

web-flow

Commit Message

Use safe string construction in Windows sysconfig join path (#1143)

## Summary
- Replace the legacy `commanjoin()`/`commajoin*()` string concatenation
in the Windows sysconfig join path with the safe `ares_buf_*` builders.

## Changes
- Drop `commanjoin`/`commajoin`/`commajoin_asciionly` (no more
`strcat`/`strncat`).
- Build the suffix and DNS server lists with `ares_buf_t`, appending
each value through a small `sysconfig_commajoin()` helper.
- A `reg_commajoin()` helper collapses the per-registry-key
read/append/free boilerplate.

## Behavior
- Output format is unchanged (comma-separated values).
- The global SearchList is now ASCII-filtered like every other suffix
source, so non-ASCII values are consistently stripped (matches #1034
ahead of the punycode work in #1031). Previously it was the one
unfiltered path.
- Empty registry values no longer emit a spurious trailing comma.

## Risk
- Low, limited to a single Windows-only file, no public API change.

Signed-off-by: @jmestwa-coder

Coverage Stats

23019 of 25098 relevant lines covered (91.72%)

12708.48 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	92.5	-2.5%	src/lib/ares_metrics.c
1	87.75	-0.12%	src/lib/record/ares_dns_record.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	28590072900.1	02 Jul 2026 12:37PM UTC	935	61.08	GitHub Action Run

c-ares / c-ares / 28590072900
90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28590072900

c-ares / c-ares / 28590072900 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28590072900

c-ares / c-ares / 28590072900
90%

README BADGES
x