supabase / cli / 28586024696
65%
develop: 65%

LAST BUILD BRANCH: gh-readonly-queue/develop/pr-5622-5a0e4a9383482808007fb6c1261b79157ee5ff5b
DEFAULT BRANCH: develop
Ran
Jobs 1
Files 229
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.019%. Remained the same
28586024696

push

github

web-flow 
fix(cli): CSV-split sso and postgres-config StringSlice flags (#5764)

## Current Behavior

Go registers `sso add/update --domains/--add-domains/--remove-domains`
and `postgres-config update/delete --config` as pflag `StringSliceVar`,
which CSV-splits each occurrence (via `encoding/csv`) and accumulates
across repeats. The legacy TS port only supported flag repetition
(`Flag.atLeast(0)`), so a single comma-separated value like `--domains
a.com,b.com` produced one malformed string (`"a.com,b.com"`) instead of
two domains — sent to the API as-is, or (for `postgres-config`) failing
the `key=value` split validation.

Fixes #CLI-1853

## Expected Behavior

`--domains a.com,b.com` (and `--config foo=bar,baz=qux`) now CSV-split
per-occurrence and accumulate across repeats, matching Go's
`pflag.StringSliceVar`/`encoding/csv` semantics exactly — including
quoted-comma handling (`'"a,b",c'` → `["a,b", "c"]`) and Go's
`csv.Reader` malformed-input error messages.

The CSV-parsing algorithm already existed for `--schema` flags (`gen
types`, `db lint`, `db dump`, `db pull`, `db diff`, `db schema
{generate,sync}`) in `legacy-schema-flags.ts`. This extracts the generic
algorithm into a new shared `legacy-string-slice-flag.ts` module
(`legacyParseStringSliceFlag`) so the four newly-fixed flags reuse it
instead of duplicating it; `legacy-schema-flags.ts` now delegates to the
shared module while keeping its schema-specific CSV re-encoder
(`legacySchemaToCsvField`) untouched.

Out of scope: the ticket's "bonus" item (aligning `sso update`'s domains
mutex error message with cobra's group-error template) is deferred — it
depends on the separate functions-mutex-template fix (CLI-1860), which
hasn't landed yet.

CLOSES CLI-1853

11007 of 16929 relevant lines covered (65.02%)

10.44 hits per line

Jobs
ID Job ID Ran Files Coverage
1 28586024696.1 229
65.02
 GitHub Action Run
Source Files on build 28586024696