nvidia-holoscan / holoscan-cli / 28579338551

77%

main: 77%

Build Type

Pull #193

github

Committed by wyli

Commit Message

fix: harden setup elevation and Kitware repo flow (review feedback)

Address three CodeRabbit findings on the setup path:

- io.py: `--dryrun` no longer requires sudo to be installed. When sudo is
  missing on a non-root host, dry-run prints the would-be `sudo ...`
  command instead of exiting; real execution still fails with the clear
  actionable message. Adds unit tests for both paths and for the
  run-directly-as-root case.

- host_setup.py: fetch and dearmor the Kitware key as two separate
  subprocess steps instead of a `wget | gpg` shell pipeline, so a download
  failure cannot be masked by the pipeline's exit status and install an
  empty keyring (also removes shell=True).

- host_setup.py: force `apt-get update` after adding the Kitware apt
  source. `_apt_updated` may already be true from an earlier step, which
  made install_packages_if_missing skip the refresh and miss Kitware's
  cmake packages.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #193: fix: install CLI in one env and elevate only per-operation

Coverage Stats

31 of 71 new or added lines in 3 files covered. (43.66%)

3 existing lines in 2 files now uncovered.

2969 of 3852 relevant lines covered (77.08%)

0.77 hits per line