nagayon-935 / kuroko / 28572456155

83%

main: 83%

Build Type

Pull #1

github

Committed by nagayon-935

Commit Message

fix: address go-review findings (races, error handling, formatting)

Fixes all HIGH/MEDIUM issues from the go-reviewer audit:
- guard Logger.Close with sync.Once to prevent a double-close race
  between normal exit and the SIGTERM/SIGHUP handler
- surface previously-discarded errors (log close, log rotation,
  selector rescan/sub-viewer) to stderr instead of silently dropping
  them
- add a bounded timeout to the notifier HTTP client so an
  unreachable webhook can no longer hang session start/end
  indefinitely, and check multipart-encoding errors in the Discord
  notifier
- extract signal-handling setup out of runWithPTY into
  forwardResizeSignals/handleTerminationSignals
- deduplicate the repeated bodyHeight calculation in viewer/selector
  into a shared helper
- switch viewer/selector text truncation from byte to rune slicing to
  avoid emitting invalid UTF-8 for multi-byte content
- clean the path argument to kuroko view
- gofmt the whole tree

Pull Request Pull Request #1: fix: address go-review findings (races, error handling, formatting)

Coverage Stats

59 of 128 new or added lines in 6 files covered. (46.09%)

2 existing lines in 2 files now uncovered.

1688 of 2064 relevant lines covered (81.78%)

63.89 hits per line