dangernoodle-io / breadboard / 28567450240

100%

push

github

refactor(bb_wifi): dedup recovery counters to /api/diag/net SSOT, drop from /api/wifi (B1-486, breaking) (#658)

/api/diag/net (bb_net_health) is now the single source of truth for wifi
recovery counters; /api/wifi (both the bb_wifi_routes.c live-fallback
emitter and the bb_pub_wifi "wifi" telemetry topic that actually backs the
route's bb_cache entry in normal operation) keeps only connection-state
fields.

Removed from /api/wifi and the "wifi" telemetry topic (bb_wifi_emit_section
+ bb_pub_wifi.c wifi_serialize):
- no_ip_recoveries
- egress_dead_count
- lost_ip_count
- recovery_count
- reason_histogram (lost_ip/egress_dead/no_ip_watchdog/top_reason_code/top_reason_count)

restart_sta_count and disconnect_rssi are unaffected (connection-state
diagnostics, not recovery counters) and remain on /api/wifi.

Old name -> new /api/diag/net name (same underlying getter, no value change):
- egress_dead_count -> egress_dead_recoveries (already existed on diag)
- lost_ip_count      -> lost_ip_recoveries (already existed on diag)

Added to /api/diag/net so no data is lost (superset of what /api/wifi had):
- no_ip_recoveries (bb_wifi_get_no_ip_count) — new field
- recovery_count (no_ip_recoveries + lost_ip_recoveries + egress_dead_recoveries) — new field
- reason_histogram (same 5 sub-fields, same source: bb_wifi_get_reason_histogram + wifi_hist_top_reason) — new field

Updated JSON-Schema fixtures and host tests for both routes plus the
"wifi" SSE/telemetry schema; added negative tests asserting the removed
fields are absent from /api/wifi and the "wifi" topic.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

1840 of 1840 branches covered (100.0%)

Branch coverage included in aggregate %.

3172 of 3172 relevant lines covered (100.0%)

1299.74 hits per line