dangernoodle-io / breadboard / 28562091915

100%

push

github

refactor(bb_arena_tls): rename bb_heap_arena and rebuild on generic bb_arena (B1-478 PR B) (#653)

- rename components/bb_heap_arena -> bb_arena_tls (header, Kconfig, CMakeLists,
  platform/{espidf,host} impls, host test) and bb_heap_arena_* symbols ->
  bb_arena_tls_*
- ESP-IDF and host impls now allocate the static backing buffer once and hand
  it to bb_arena_init() (generic bump-alloc primitive from B1-478 PR A)
  instead of hand-rolling a multi_heap/bump allocator per platform
- behavior-neutral at BB_ARENA_TLS_BYTES=0 (default): mbedTLS calloc/free
  route straight to the fallback path, same as before the rename
- #610's fallback routing through bb_calloc_internal/bb_mem_free is
  preserved verbatim on both platforms
- bb_mqtt Kconfig/header/espidf comments updated to the new name; no API
  change (bb_mqtt never called bb_heap_arena_* directly)
- fix critical regression: bb_arena is a bump allocator that never reclaims
  on free, so once the arena filled on the first mbedTLS handshake it never
  served another handshake for the rest of device uptime. Track outstanding
  arena allocations and call bb_arena_reset() once the count drains to zero
  (arena fully drained between handshakes), restoring multi-handshake reuse
  while staying safely in fallback if anything remains pinned
- Kconfig help text corrected to describe reset-on-drain semantics and to
  size BB_ARENA_TLS_BYTES for a handshake's cumulative allocation, not peak
  concurrent bytes
- add test_arena_tls_reuse_after_free_all covering the drain-and-reuse path
- guard the process-wide calloc/free hooks with a pthread mutex held across
  the entire body of both (ESP-IDF and host impls) so concurrent TLS
  handshakes (telemetry sink + OTA/update-check, WPA-supplicant) cannot
  corrupt the bump offset or race the outstanding counter into a premature
  reset (UAF)
- make bb_arena_tls_init() idempotent on both platforms: a second call no
  longer zeros the outstanding counter or rewinds the a... (continued)

1840 of 1840 branches covered (100.0%)

Branch coverage included in aggregate %.

3167 of 3167 relevant lines covered (100.0%)

1291.01 hits per line