hyperscale-stack / businessid / 28557907829

94%

push

github

fix: apply code-review findings

Correctness:
- VAT: alnum key returns Unsupported before SIREN Luhn (spec fix);
  ValidateChecksum now enforces country-mismatch; Canonicalize no
  longer prepends the country code to an empty value.
- Validator: typed-nil providers no longer panic at construction;
  format/checksum/registry callers get a wrapped error instead of a
  nil-pointer deref when a provider returns (nil, nil); checksum
  hard-requires a FormatValidator (matches doc comment).
- Add ReasonUnsupportedFormat so a missing FormatValidator is
  distinguishable from an unregistered kind.
- SIREN, SIRET, LEI: ValidateChecksum surfaces ReasonEmpty on empty
  input instead of ReasonInvalidChecksum.
- UK company number: Canonicalize strips '.' and '-' like peers.
- National registration number: report ReasonEmpty before
  MissingCountryCode when both are absent.
- Validation results now preserve the caller's raw value in
  InputValue (validator injects it after every dispatch).

API and efficiency:
- RegistryResult gains Kind + InputValue.
- Validate() canonicalizes once, format-checks once, and dispatches
  checksum inline with the shared canonical value.

Cleanup:
- Extract IsRegistrationCharset and IsASCIICountryPrefix to the root
  package; remove four duplicate helpers across providers.
- Drop unused sirenLen constant; simplify validateFRFormat to mutate
  in place.

Coverage: 100 % across every package; make lint clean.

177 of 177 new or added lines in 10 files covered. (100.0%)

1081 of 1081 relevant lines covered (100.0%)

8.27 hits per line