tarantool / luajit / 28554408869

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Prevent sanitizer warnings for lj_tab_new*() and table.new().

Reported by Sergey Bronnikov.

(cherry picked from commit 8f421c81e)

The Undefined Behaviour Sanitizer [1] produces a warning because
the function `lua_createtable()` takes signed integer arguments,
but the `lj_tab_new_ah()` was not properly validating or converting
these signed values before using them in unsigned arithmetic.

The fix changes the signature of `lj_tab_new_ah()` to accept
uint32_t directly, and adjusts `lua_createtable()` to cast the
incoming signed int values to uint32_t before passing them.

[1]: https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html

Sergey Bronnikov:
* added the description and the test for the problem

Part of tarantool/tarantool#12480

Reviewed-by: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 6f31297f8)

Coverage Stats

5713 of 6039 branches covered (94.6%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

15 existing lines in 3 files now uncovered.

21764 of 23464 relevant lines covered (92.75%)

1937006.49 hits per line