MerginMaps / python-api-client / 28545728839

83%

master: 83%

Build Type

Pull #306

github

Committed by wonder-sk

Commit Message

Fix issues with SSL certificates

Urllib's default handling of SSL certs is rather inconsistent: on linux/mac it
should use some system openssl path (which on mac may not be present), and on windows
it should use system certificate store.

Our old macOS workaround was apparently preventing usage of system certificate store
on windows as well, and using the old vendored cert.pem instead. The fix is to use SSL
certificates from OS certificate store, using truststore python module.

The truststore module requires python 3.10+ so we bump the minimum python dependency.

Pull Request Pull Request #306: Fix issues with SSL certificates

Coverage Stats

6 of 12 new or added lines in 2 files covered. (50.0%)

11 existing lines in 2 files now uncovered.

4731 of 5675 relevant lines covered (83.37%)

0.83 hits per line