medplum / medplum / 28544137642

92%

push

github

fix(core/fhirpath): `as` should return empty collection on wrong type (#9711)

* fix(core/fhirpath): `as` should return empty collection on wrong type

Signed-off-by: Derrick Farris <derrick@medplum.com>

* fix(core/fhirpath): handle when RHS is not valid type identifier

Signed-off-by: Derrick Farris <derrick@medplum.com>

* fix(core): fix ofType with qualified type names and singleton error spacing

Resolve FHIRPath type specifier atoms in ofType() via getTypeName so
qualified names like FHIR.Patient match correctly, and correct the
spacing in the singleton() error message.

Signed-off-by: Derrick Farris <derrick@medplum.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(core): fix 'is' operator crash on qualified type names; unskip testType

The 'is' operator (IsAtom) resolved its right operand via
(this.right as SymbolAtom).name, which is undefined for a qualified
name like System.Boolean, crashing fhirPathIs on undefined.startsWith.
Use the shared getTypeName helper (now exported) instead, matching the
is() function and ofType().

Unskip the testType block; the 5 tests that require System-vs-FHIR
namespace semantics (not yet implemented) are individually skipped with
a TODO.

Signed-off-by: Derrick Farris <derrick@medplum.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Signed-off-by: Derrick Farris <derrick@medplum.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

21619 of 24564 branches covered (88.01%)

Branch coverage included in aggregate %.

18 of 20 new or added lines in 3 files covered. (90.0%)

38539 of 40889 relevant lines covered (94.25%)

12562.25 hits per line