kubernetes-sigs / lws / 28529019012

56%

main: 56%

Build Type

Pull #907

github

Committed by hasB4K

Commit Message

fixtures: honor explicit Image field even when slow-pod fields are set

The slow-pod branch was unconditionally overriding p.Image to
`busybox:1.36`, which meant a test passing two different explicit
images (e.g. `busybox:1.36` for initial and `busybox:stable` for
target) got byte-identical yaml on both applies. No rolling update
was ever triggered, and the Slow-Rollout e2e test timed out at 8min
in CI without observing a single state transition.

Fix: only default to busybox when p.Image is empty. If the caller
passes an explicit image, keep it.

Validated locally: the Slow Rollout e2e test now completes in ~32s
with the expected 5 observed states.

Signed-off-by: Mathis Felardos <mathis@mistral.ai>

Pull Request Pull Request #907: DisaggregatedSet: don't stall on slow pods and use the full range of maxUnavailable to maxSurge.

Coverage Stats

184 of 194 new or added lines in 2 files covered. (94.85%)

7 existing lines in 2 files now uncovered.

2015 of 3697 relevant lines covered (54.5%)

158.09 hits per line