dcdpr / jp / 28528159995

69%

Build Type

push

github

Committed by web-flow

Commit Message

feat(config, cli): Implement RFD 081 `enable` decomposition (#819)

The tool `enable` field is decomposed from a flat enum (`On`, `Off`,
`Explicit`, `Always`) into a two-field struct with a boolean `state` and
an `allow_toggle` policy (`any`, `never`, `if_named`,
`if_named_or_group`). The resolved form (`Enable`) is produced on
demand; config files, `base_config.json`, and `config_delta` events all
store and load the partial form (`PartialEnableConfig`).

Config accepts a bool shorthand, a legacy string (`"on"`, `"off"`,
`"explicit"`, `"always"`), or a table:

```toml
enable = true                                     # freely toggleable
enable = { state = false, allow_toggle = "if_named" }
enable = { state = true, allow_toggle = "never" } # locked-on
```

The directive engine in `apply_enable_tools` now consults
`Enable::accepts(scope)` before flipping a tool's state. Bulk directives
(`-t` / `-T` with no argument) silently skip tools whose policy forbids
a bulk flip; named directives that name a locked tool return a
user-visible error (`cannot disable \`describe_tools\`: this tool is
configured as locked-on`). The `describe_tools` builtin is registered as
`PartialEnableConfig::LOCKED_ON`.

The config validator now rejects `assistant.tool_choice = "<tool>"` when
the named tool resolves to locked-off — a locked-off tool is never sent
to the assistant, so forcing it would silently reference a tool that
does not exist in the tool list. `tool_definitions()` in `jp_llm`
enforces the same: locked-off tools are dropped even when named by
`forced_tool`.

`deep_merge_toml` is widened to recurse into inline tables so that a
nested key assignment like `conversation.tools.foo.enable.state` merges
the subfield instead of replacing the whole inline table.

Legacy string values normalize to the table form on the first
write-back, the same shorthand-to-table normalization `ModelIdConfig`
already performs.

RFD 081 status updated to Implemented. RFDs 055, 056, 057, and... (continued)

Coverage Stats

197 of 216 new or added lines in 8 files covered. (91.2%)

5 existing lines in 4 files now uncovered.

37867 of 55829 relevant lines covered (67.83%)

689.0 hits per line