Mellanox / network-operator / 28523311028

63%

Build Type

push

github

Committed by web-flow

Commit Message

chore: bump Go to 1.26 and Kubernetes dependencies to 1.36 (#2646)

Upgrade the project to Go 1.26 and Kubernetes 1.36 (k8s.io/* v0.36.1),
along with all tooling and API adaptations required by those bumps.

Go / module changes
- go.mod: set `go 1.26.0`; upgrade k8s.io/* from v0.34.8 → v0.36.1,
sigs.k8s.io/controller-runtime v0.22.5 → v0.24.1, and all transitive
dependencies (klog, kube-openapi, prometheus, grpc, kustomize, …)

Makefile tooling
- golangci-lint: v2.11.4 → v2.12.2 (first release that fully supports Go
1.26)
- Add GO_MOD_VERSION variable and pass GOTOOLCHAIN=go$(GO_MOD_VERSION)
to every go-install-tool invocation so tools are always built with the
same Go version declared in go.mod, preventing the "build version lower
than targeted version" error
- controller-gen: v0.19.0 → v0.21.0 (k8s v0.36 / Go 1.26 aligned
release)
- setup-envtest: release-0.22 → release-0.24 (tracks controller-runtime
v0.24)
- ENVTEST_K8S_VERSION: 1.28 → 1.36

API / webhook changes
- api/v1alpha1/groupversion_info.go: replace deprecated
sigs.k8s.io/controller-runtime/pkg/scheme.Builder with
k8s.io/apimachinery/pkg/runtime.NewSchemeBuilder; register all five CRD
types centrally via addKnownTypes() and metav1.AddToGroupVersion()
- api/v1alpha1/*_types.go: remove per-file init()
SchemeBuilder.Register() calls now that registration is centralised
- api/v1alpha1/validator/*_webhook.go: migrate from deprecated
webhook.CustomValidator (Validator[runtime.Object]) to the typed
admission.Validator[*ConcreteType] interface; update
NewWebhookManagedBy(mgr, &Type{}) call (object moved from .For() to the
constructor in controller-runtime v0.24); switch back to WithValidator()
now that validators are properly typed; drop runtime.Object type
assertions from each ValidateCreate/Update/Delete method

Bug fixes
- pkg/nodeinfo/filter.go: update ToleratesTaint() call to the new k8s
1.36 signature (logger klog.Logger, taint *Taint,
enableComparisonOperators bool); pass klog.Background() ... (continued)

Coverage Stats

16 of 25 new or added lines in 5 files covered. (64.0%)

49 existing lines in 5 files now uncovered.

4938 of 7897 relevant lines covered (62.53%)

44.97 hits per line