ben-manes / caffeine / #5567

100%

master: 100%

push

github

Publish the pacer future with release/acquire

Pacer.future is written under the eviction lock but read lock-free by
isScheduled() (rescheduleCleanUpIfIncomplete's fast path, before the
tryLock). As a plain field the lock-free reader has no happens-before to
the write: the unlock is a release of the lock monitor, not of the
field, and the reader never acquires the lock. A Scheduler that returns
an unsafely-published Future could then expose it partially constructed
to the isDone() call. Write it with setRelease and read it with
getAcquire.

Narrow -- the built-in schedulers return safely-published futures and
reference reads are atomic, so this is formal hardening; the staleness
of the fast-path read is benign (re-checked under the lock). 80b9a4b5d
snapshotted the read into a local; this adds the missing edge.

4047 of 4056 branches covered (99.78%)

5 of 5 new or added lines in 1 file covered. (100.0%)

8260 of 8261 relevant lines covered (99.99%)

1.0 hits per line