source-academy / py-slang / 28496101773

78%

push

github

fix: remove evaluator build from prepublishOnly (#174)

* fix: remove evaluator build from prepublishOnly

The evaluator bundles (PyCseEvaluator*.js) are CDN artifacts deployed
separately to GitHub Pages — they are not part of the npm package and
should not be built during npm publish. Running `yarn build --all` in
prepublishOnly pulled in PyCseMachinePlugin.ts and python-grammar.ts,
which have TypeScript warnings that some environments treat as errors,
blocking publish.

prepublishOnly now builds only the library (dist/index.cjs) and the
CLI (dist/repl.cjs), both of which build cleanly.

* fix: resolve TypeScript warnings in lib and evaluator builds

- PyCseMachinePlugin.ts: cast rawControlStack to ControlStackItem[] to
  fix TS2345 (ControlItem not assignable to ControlStackItem); use
  optional chaining on endTok.indexInSource to fix TS18048
- python-grammar.ts: prepend @ts-nocheck to suppress TS4094 on the
  auto-generated nearley parser class
- python-grammar.ts.sed: add sed rule so @ts-nocheck is preserved on
  future grammar regenerations

Fixes pre-existing warnings that appeared during both evaluator builds
and the npm library build (build:lib).

* fix: remove private modifier from PythonLexer internal fields

TypeScript TS4094 fires when an exported value's inferred type contains
private/protected class members. python-grammar.ts exports an instance
of PythonLexer as part of its default export, so TypeScript surfaced
pos and tokens as private fields of an exported anonymous type.

Removing private from these two implementation fields resolves the error
without suppressing diagnostics. The fields are internal state but there
is no external API contract that requires them to be private.

Also reverts the @ts-nocheck approach from the previous commit and
removes the corresponding sed rule, since the root cause is now fixed.

2212 of 3198 branches covered (69.17%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

5567 of 7016 relevant lines covered (79.35%)

12690.49 hits per line