911
67%

Ran 24 Sep 2016 09:43AM UTC

Jobs 1

Files 7

Run time 0s

Badge

Embed ▾

pending completion

Build # 911

Build Type

push

travis-ci

Committed by

Fuco1

Commit Message

Fix autoskipping closing chevrons in rust-mode (#651)

Before this commit, closing chevrons were not autoskipped.  Typing:

`T<` would result in the correct insertion of a matching closing
chevron: `T<|>`, but typing `>` would not result in `T<>|>`, not
skipping the closing chevron even with the `autoskip` action set on the
pair.

This was caused by the regexp in `sp-rust-could-be-parameterized` set as
a `when` filter for the local pair "<" ">".  This filter is called by
`sp--do-action-p` not only when inserting a chevron, but also when
determining if the closing chevron should be autoskipped.  In the
closing case, the regexp does not match, because at the moment this
check is done the code contains one extra chevron: `<T>|>`.

In fact, the filter `sp-rust-could-be-parameterized` was implicitly
concerned only with the `insert` action, and not the other ones.

This commits rewrites the filter to explicitly disallow some cases where
a matching bracket should not be inserted.

Closes #642.

Run Details

2358 of 3716 relevant lines covered (63.46%)

3107.21 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	911.1 (EVM_EMACS=emacs-24.4-bin)	24 Sep 2016 09:43AM UTC	7	63.46	Travis Job 911.1

Source Files on build 911

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

Fuco1 / smartparens / 911
67%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 911

Fuco1 / smartparens / 911 67%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 911

Fuco1 / smartparens / 911
67%

README BADGES
x