dguerri / k8s-ssh-gateway-controller / 28494511285

91%

push

github

fix(ssh): cancel wrong-hostname tunnels using requested host:port

Previously handleAssignedURIs canceled forwardings using the
server-bound port parsed from tcp:// URIs. Per RFC 4254 §7.1, sish and
other servers key cancel-tcpip-forward on the originally-requested bind
address and port, so canceling the bound value never matched and leaked
the listener. Worse, HTTP/HTTPS tunnels (e.g. pico.sh web tunnels) have
no tcp:// URI, so no cancel was sent at all.

Now cancel always uses the originally-requested host:port, releasing the
listener for both TCP and HTTP/HTTPS forwardings. Tests updated and a new
test added covering the HTTP/HTTPS case.

7 of 7 new or added lines in 1 file covered. (100.0%)

2012 of 2215 relevant lines covered (90.84%)

9.14 hits per line