ben-manes / caffeine / #5566

100%

push

github

Use immutable entries in EntrySet.removeIf (match CHM)

ConcurrentHashMap and Guava hand removeIf's predicate an immutable
snapshot so setValue throws (JDK-8078726); only iterator/toArray are
write-through. Caffeine diverged: the sync views passed a
WriteThroughEntry (unbounded passed a raw map entry whose setValue
silently bypassed notifications), and the async raw view inherited the
default removeIf, removing positionally rather than conditionally.

Hand the predicate a Map.entry() snapshot and remove conditionally in
the bounded and unbounded views; the async views delegate to the inner
cache's entrySet().removeIf, mirroring their values().removeIf.

The Guava adapter's forwarding views already delegated removeIf but
inherited the JDK default forEach/spliterator/stream (Guava's
Forwarding classes don't forward Java-8 defaults), so the spliterator
reported SIZED instead of Caffeine's CONCURRENT. Delegate forEach and
spliterator (covering stream too) on the views and forEach on the map
view, and add tests pinning the removeIf immutable-snapshot contract
and the CONCURRENT characteristic.

4048 of 4056 branches covered (99.8%)

27 of 27 new or added lines in 4 files covered. (100.0%)

8258 of 8259 relevant lines covered (99.99%)

1.0 hits per line