dangernoodle-io / breadboard / 28482480551

100%

push

github

refactor(config): PSRAM-axis Kconfig derives, snap static_asserts, heap-classifier coverage (B1-434, B1-435, B1-439) (#616)

PART 1 — DERIVE (B1-435)

bb_pub/Kconfig: BB_PUB_TELEM_SNAP_MAX and BB_PUB_TELEM_SERIALIZE_MAX now
derive from SPIRAM: default 1024 when CONFIG_SPIRAM=y (bitaxe), default 512
otherwise (wroom32, tdongle-s3, c3-supermini, s2-mini).  Kconfig defaults are
lowest precedence, so TaipanMiner's explicit sdkconfig fragment values still
win — no behavior change on any currently-shipped board.  The derive closes
the silent-misconfiguration window for boards that don't carry an explicit
fragment entry (the TA-505 S2 root cause: sdkconfig.defaults=1024 was
inherited because the S2-mini fragment lacked the override; TM #607 fixed it
with an explicit override, this derive prevents the class from recurring).

bb_mdns/Kconfig: BB_MDNS_BATCH_RING_DEPTH derives SPIRAM-axis: default 4
with SPIRAM (ring lives in SPIRAM, large batches affordable), default 3
without (internal heap bottleneck; aligns with TaipanMiner sdkconfig/no-psram
which sets 3 explicitly).  BB_MDNS_BATCH_MAX is intentionally NOT derived here
— it is set for DIFFERENT reasons by both single-core and no-PSRAM TM
fragments (the single-core axis is orthogonal to the PSRAM axis).  RING_DEPTH
is the cleanly PSRAM-axis knob.

TaipanMiner cross-repo note (do NOT change TM in this PR): after this lands,
the following TM fragment lines become REDUNDANT and can be dropped in a
re-pin:
  sdkconfig/no-psram: BB_PUB_TELEM_SERIALIZE_MAX=512, BB_PUB_TELEM_SNAP_MAX=512,
                      BB_MDNS_BATCH_RING_DEPTH=3
  sdkconfig/esp32-s2-mini: any duplicated 512 caps that chain from no-psram

PART 2 — ENFORCE (B1-434)

Add compile-time static_assert (negative-array-size idiom) for every telem
snap_t struct that was missing one:
  - bb_pub_power.c  → _power_snap_size_check
  - bb_pub_fan.c    → _fan_snap_size_check
  - bb_pub_wifi.c   → _wifi_snap_size_check
  - bb_pub_thermal.c → _thermal_snap_s... (continued)

1850 of 1850 branches covered (100.0%)

Branch coverage included in aggregate %.

3190 of 3190 relevant lines covered (100.0%)

1225.03 hits per line