SRombauts / SQLiteCpp / 28478168866

100%

master: 100%

Pull #559

github

Fix Savepoint destructor exception-safety and rollback bookkeeping

The destructor caught only SQLite::Exception, so a std::bad_alloc thrown
while building the "ROLLBACK TO SAVEPOINT ..." / "RELEASE SAVEPOINT ..."
strings (or any other non-SQLite exception) escaped the implicitly noexcept
destructor and called std::terminate. Broaden the handler to catch(...).

Track an explicit mbRolledBack state so the destructor issues the minimum
commands: when a rollback already happened (manual rollbackTo(), or the
scope-exit path), it now does a single RELEASE instead of relying on SQLite
tolerating a repeated ROLLBACK TO. The documented auto-rollback semantics
are unchanged.

Add a regression test covering a manual rollbackTo() followed by release().

Fixes SP-02 and SP-03 from the code review.

4 of 4 new or added lines in 2 files covered. (100.0%)

641 of 643 relevant lines covered (99.69%)

34.41 hits per line