umputun / remark42 / 28478066299

84%

master: 84%

Pull #2097

github

Remove go-chi/chi/v5/middleware and consolidate request middlewares

With RealIP (#2099) merged, middleware.Timeout was the last use of
go-chi/chi/v5/middleware. Swap it for the local timeout helper (context
deadline + 504, matching chi; covered by TestTimeout), removing the
dependency entirely (the chi router itself stays until the router migration).

Consolidate all request-scoped middlewares into middleware.go and their
tests into middleware_test.go:
  funcs:  timeout (from ssl.go); rejectAnonUser, matchSiteID, cacheControl,
          apiCSPMiddleware, securityHeadersMiddleware, subscribersOnly,
          validEmailAuth, rateLimiter (from rest.go)
  tests:  TestTimeout (from ssl_test.go); TestRest_rejectAnonUser,
          TestRest_cacheControl, TestRest_apiCSP, TestRest_securityHeaders,
          TestRest_subscribersOnly, Test_validEmailAuth, TestRest_matchSiteID
          (from rest_test.go)

Pure relocation plus the Timeout swap. go test -race, vet, golangci-lint
and govulncheck all clean; example module builds.

142 of 149 new or added lines in 2 files covered. (95.3%)

6390 of 7576 relevant lines covered (84.35%)

36.37 hits per line