kubevirt / hyperconverged-cluster-operator / 28477311386

81%

push

github

 netresinjector: Make deployment conditional on spec field (#4346)

* api: Add v1-only fields conversion framework

Introduce a generic framework for handling v1-only fields during
API version conversion between v1 and v1beta1. This addresses the
issue where fields that only exist in v1 would be lost when users
modify the HyperConverged CR using the v1beta1 API.

The framework uses an annotation-based approach:
- When converting v1 → v1beta1, v1-only fields are stored in the
  annotation 'hco.kubevirt.io/v1-only-fields' as JSON
- When converting v1beta1 → v1, the fields are restored from the
  annotation and then the annotation is removed

This is a generic framework that can be extended for future v1-only
fields by adding them to the v1OnlyFields struct and updating the
store/restore logic.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Nir Dothan <ndothan@redhat.com>

* api: Add deployNetworkResourcesInjector field to DeploymentConfig

Currently, there are 2 operators in the OLM catalog that deploy the
netwrok-resources-injector webhook: HCO and SR-IOV Network Operator.
While they are safe to use concurrently, users can benefit from
disabling one instance.
In such cases the instance that should be disabled is the HCO one,
because its scope is specific to CNV, while the other one has a more
general scope.

Adds spec.deployment.deployNetworkResourcesInjector boolean field to
control deployment of the network-resources-injector component.

When enabled (default: true), the network-resources-injector mutating
webhook is deployed to automatically inject resource requests for
custom resources annotated in NetworkAttachmentDefinition.

This is a deployment configuration field (not a feature gate),
allowing users to opt-out of the network-resources-injector if needed.

Signed-off-by: Nir Dothan <ndothan@redhat.com>
Assisted by: Claude Sonnet 4.5 <noreply@anthropic.com>

* netresinjector: Make deployment conditional on spec field

Mak... (continued)

155 of 159 new or added lines in 8 files covered. (97.48%)

11338 of 13924 relevant lines covered (81.43%)

2.18 hits per line