medplum / medplum / 28471579753

92%

main: 92%

push

github

[Provider] Hide slots related to cancelled appointments (#9686)

* [Provider] Hide slots related to cancelled appointments

If you have created an appointment with attributes like "bufferBefore",
then when you use `$cancel` the Slot resource created to enforce that
is also soft-deleted.

When you do this from the Provider UI, we want to clear such Slots from
the calendar. We don't get the Slot resources back in the update
response (as they have been deleted), so we inspect `Appointment.slot`
to find references to the related Slot resources we can hide.

Signed-off-by: Noah Silas <noah@medplum.com>

* PR Feedback

Claude correctly called out that we were storing "merged" slots in the
component state, and so trying to clear out only parts of a merged slot
could cause confusing UI bugs.

We now store the "raw" slots in the state, and derive the "merged" slot
state from that in a separate memo. This way we can update the state and
then the merge will re-run and derive new updated state.

In the long term I think we probably will want to drop this merge code,
as it means that our UI is not as reflective of reality, or prepare some
alternative way to drill in to the respective slots, but for now this is
an easy way to improve correctness.

Signed-off-by: Noah Silas <noah@medplum.com>

* PR Feedback

Signed-off-by: Noah Silas <noah@medplum.com>

---------

Signed-off-by: Noah Silas <noah@medplum.com>

21580 of 24529 branches covered (87.98%)

Branch coverage included in aggregate %.

38505 of 40859 relevant lines covered (94.24%)

12528.03 hits per line