SRombauts / SQLiteCpp / 28461402948

100%

master: 100%

Pull #558

github

Fix getHeaderInfo() signed-shift UB and use fixed-width Header types

The big-endian assembly shifted unsigned char operands that promote to int,
so bytes with the high bit set produced signed left-shift UB and sign-extended
when widened to the Header fields. Cast each byte to uint32_t before shifting,
via a local readBE32 helper that also removes the repetitive byte arithmetic.

Header used platform-variable `unsigned long` (32-bit on LLP64 Windows, 64-bit
on LP64), giving a cross-platform field-width mismatch. Switch the struct to
fixed-width <cstdint> types (uint8_t / uint32_t).

Fixes DB-02 and DB-03 from the code review.

21 of 21 new or added lines in 1 file covered. (100.0%)

639 of 641 relevant lines covered (99.69%)

34.22 hits per line