vocdoni / saas-backend / 28458004928

63%

push

github

fix(api): enforce integrator process quota on the /transactions path

PR #557 added an `if !managed(org)` skip in HasTxPermission, deferring the
managed-org process-count check to the integrator's aggregate ManagedProcesses
quota (ReserveManagedPublish) "at publish time". But that reservation was only
wired into publishProcessHandler (/process/{id}/publish); the remote-signer
/transactions path (signTxHandler) — the primary SDK flow — was left calling
HasTxPermission with the check skipped and never reserving.

Result: managed orgs could mint unlimited non-test elections via /transactions,
bypassing the integrator cap, and /integrator under-reported ManagedProcesses.

Extract the reserve logic from publishProcessHandler into a shared
reserveManagedProcessSlot helper and call it from both NEW_PROCESS entry points
so they cannot drift apart again. signTxHandler rolls the reservation back if
signing fails, mirroring the publish path.

Adds TestIntegratorProcessQuotaViaTransactions covering the counter increment,
the aggregate cap, and the test-sized exemption on /transactions.

36 of 52 new or added lines in 2 files covered. (69.23%)

10301 of 16406 relevant lines covered (62.79%)

44.98 hits per line