adobe / spectrum-web-components / 28453023513

96%

push

github

feat(core): migrate ColorController to 2nd-gen and optimize with colorjs.io (#6450)

* feat(core): migrate ColorController to 2nd-gen and optimize with colorjs.io

Relocate ColorController from 1st-gen reactive-controllers into
@spectrum-web-components/core controllers, and optimize the implementation
using colorjs.io built-ins without changing any output color formats.

Changes:
- Add controllers/color-controller (src + index) and export from
  controllers/index.ts; add colorjs.io@0.5.2 dependency, package exports,
  and typesVersions; externalize colorjs.io in the build.
- Optimizations (no output-format change): hoist regex arrays to module
  constants, remove dead getColor formats (hsva/hsla are not real colorjs
  spaces and throw), dedupe space-id detection into a shared helper,
  centralize Dev Mode warnings behind a typeof-window guard for SSR/Node
  safety, and tighten internal types.
- Port the controller test suite as a pure-logic Node unit test under
  test/__unit__, activating the dormant core-unit Vitest project.
- Exclude test/__unit__ from the Storybook story indexer so unit tests are
  not indexed as CSF.

1st-gen ColorController and its consumers are untouched.

* test(core): follow placement-controller convention for ColorController test

Replace the Node-unit `test/__unit__/color-controller.test.ts` with a
Storybook play test at `test/color-controller.test.ts`, matching the folder
and file structure used by placement-controller. The assertions run as `play`
functions in the storybook Vitest project against a minimal non-rendering host.

Reverts the now-unneeded scaffolding: the dormant `core-unit` Vitest project
in swc/vitest.config.js stays commented out, and the Storybook story indexer
no longer needs a `__unit__` exclusion.

* docs(core): add ColorController docs page following placement-controller

Add a per-unit MDX docs page and Storybook stories for ColorController,
mirroring the placement-controller structure: a `demo-color-... (continued)

6017 of 6459 branches covered (93.16%)

Branch coverage included in aggregate %.

37902 of 39173 relevant lines covered (96.76%)

458.82 hits per line