kubeovn / kube-ovn / 28436253864

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix: allow multi SNAT with same logical_ip (#6942)

* fix: allow multiple SNAT rules with different external_ip but same logical_ip

Previously, GetNat for SNAT type only matched on logical_ip, causing:
1. Silent creation skip when adding a second SNAT with different
   external_ip but same logical_ip (NatExists found the first rule)
2. Wrong rule deletion (always deleted the first match by logical_ip)

Changes:
- GetNat SNAT filter: match on (external_ip, logical_ip) when
  external_ip is non-empty; empty external_ip falls back to
  logical_ip-only for backward compatibility
- UpdateSnat: pass actual external_ip to GetNat; return early when
  matching SNAT already exists (idempotent)
- Unit tests: use actual external_ip in GetNat calls
- E2E tests: add multi-SNAT, multi-FIP, multi-DNAT scenarios with
  different EIPs from different external subnets, verifying CRD-OVN
  backend precision and deletion independence

Closes #6841

---------

Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>

Coverage Stats

5 of 17 new or added lines in 2 files covered. (29.41%)

3 existing lines in 2 files now uncovered.

16356 of 60276 relevant lines covered (27.14%)

0.32 hits per line