SRombauts / SQLiteCpp / 28433029871

100%

push

github

Fix unreliable 16-byte header check in Database::isUnencrypted() (#553)

isUnencrypted() used ifstream::getline() to read the SQLite magic
string, which stops at a newline or NUL and never compares the 16th
byte, so the security gate was unreliable and could read uninitialized
stack memory on a short file.

- Read exactly 16 raw bytes with read() in binary mode and verify
gcount() == 16 (a shorter file returns false instead of comparing
garbage), then compare with memcmp, mirroring getHeaderInfo().
- Add a regression test covering a valid database, a too-short file, and
a 16-byte garbage header.

5 of 5 new or added lines in 1 file covered. (100.0%)

685 of 687 relevant lines covered (99.71%)

30.36 hits per line