medplum / medplum / 28415910930

92%

push

github

Perf/cache compartment fhirpath (#9691)

* perf(server): cache parsed patient-compartment FHIRPath expressions

getPatients() runs on every resource write to compute meta.compartment.
For each patient-compartment search parameter it called
evalFhirPath(searchParam.expression, resource) with the raw expression
string, which re-tokenizes and re-parses the FHIRPath expression on every
call -- so the same fixed set of compartment expressions was re-parsed for
every resource written.

Cache the parsed FhirPathAtom per expression string (bounded by the number
of distinct compartment search params) so each expression is parsed once.
Parsing is deterministic, so the cached AST is identical to re-parsing;
there is no behavior change.

Signed-off-by: Joshua Kelly <josh@flexpa.com>

* Use cached value

Signed-off-by: Cody Ebberson <cody@ebberson.com>

---------

Signed-off-by: Joshua Kelly <josh@flexpa.com>
Signed-off-by: Cody Ebberson <cody@ebberson.com>
Co-authored-by: Joshua Kelly <josh@flexpa.com>

21580 of 24529 branches covered (87.98%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

38505 of 40859 relevant lines covered (94.24%)

12527.91 hits per line