kubeflow / trainer / 28412576741

65%

Build Type

push

github

Committed by web-flow

Commit Message

chore(test): add unit tests for TorchTune plugin helpers (#3599)

* test(torch): add unit tests for getModelFromRuntimeRef

Cover the runtime-ref name parsing used to resolve the TorchTune
pretrained model: normalization of valid names and the empty-string
fallback for malformed refs (wrong number of parts, empty input).


Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

* test(torch): add unit tests for isLoraConfigEnabled

Cover LoRA detection from trainer args: the model.lora_attn_modules
marker present, absent, and the empty-args case.


Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

* test(torch): add unit tests for isUseQLoraFinetune

Cover QLoRA detection from trainer args, including the DoRA
short-circuit that disables QLoRA even when quantize_base is set.


Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

* test(torch): add unit tests for getRecipeAndConfig

Cover the recipe/config selection matrix: single-device, single-node
multi-GPU, and multi-node, each across full / LoRA / QLoRA fine-tuning.


Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

* test(torch): add unit tests for extractOverridesFromRuntime

Cover extraction of immutable runtime config overrides from the JobSet
template: trainer-ancestor node container returns only immutable configs,
while non-trainer ancestors, non-node containers, and an absent template
yield no overrides.


Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

* test(torch): use year-less copyright header

Align the new test file with the repo boilerplate (hack/boilerplate/boilerplate.go.txt) and CNCF/LF guidance, which drop the year from the copyright notice.

Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

* test(torch): cover integer numProcPerNode in getRecipeAndConfig

Exercise integer numProcPerNode counts alongside the existing "auto" cases: numProcPerNode=1 forces the single-device recipe even with multiple GPUs, while a count >1 takes the distributed path.

Signed-off-b... (continued)

Coverage Stats

12 of 13 new or added lines in 1 file covered. (92.31%)

3 existing lines in 1 file now uncovered.

2361 of 3619 relevant lines covered (65.24%)

0.76 hits per line