tomdesair / tus-java-server / 28395814495

95%

push

github

🛡️ Sentinel: [HIGH] Fix CRLF injection in Content-Disposition header (#94)

* 🛡️ Sentinel: [HIGH] Fix CRLF injection in Content-Disposition header

This commit sanitizes the `filename` parameter in the `Content-Disposition` header in `DownloadGetRequestHandler.java`. By removing carriage returns (`\r`), line feeds (`\n`), and double quotes (`"`), we prevent HTTP Response Splitting / CRLF Injection vulnerabilities. The URL-encoded `filename*` parameter remains fully capable of handling special characters safely.

Also added `DownloadGetRequestHandlerSecurityTest.java` to prevent regression.

Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>

* 🛡️ Sentinel: [HIGH] Fix CRLF injection in Content-Disposition header

This commit sanitizes the `filename` parameter in the `Content-Disposition` header in `DownloadGetRequestHandler.java`. By removing carriage returns (`\r`), line feeds (`\n`), and double quotes (`"`), we prevent HTTP Response Splitting / CRLF Injection vulnerabilities. The URL-encoded `filename*` parameter remains fully capable of handling special characters safely.

Also added `DownloadGetRequestHandlerSecurityTest.java` to prevent regression.

Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>

623 of 700 branches covered (89.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1811 of 1864 relevant lines covered (97.16%)

6.57 hits per line