nette / application / 28395552768

84%

master: 0%

push

github

ParameterConverter: malformed current-request params in self-links return 4xx, not 500

Building a 'this'/self link re-validates the current request's own
(client-controlled) parameters via toParameters(). When such a value cannot be
coerced to the target action signature it now throws
InvalidRequestParameterException (a subtype of InvalidLinkException);
redirect()/redirectPermanent()/forward() degrade it to a BadRequestException
(4xx) and isLinkCurrent() to false, while link()/canonicalize() keep rendering
'#error'. Explicitly passed link arguments still throw plain InvalidLinkException,
preserving programmer-error detection.

16 of 20 new or added lines in 3 files covered. (80.0%)

2050 of 2444 relevant lines covered (83.88%)

0.84 hits per line