supabase / supabase-flutter / 28390347724

86%

push

github

fix(storage): preserve sortBy defaults when list receives a partial sortBy (#1490)

## What

`storage.from(bucket).list()` rejected a partially-specified `SortBy`
with a 400.

`SortBy`'s constructor had no default for `column`/`order`, so
`SortBy(column: 'updated_at')` left `order` as `null`. Since
`SearchOptions.toMap()` always emits both keys and the storage client
serializes with `json.encode` (which keeps nulls), the request body
sent:

```json
"sortBy": { "column": "updated_at", "order": null }
```

The Storage server requires both `column` and `order`, so it returned a
400.

This mirrors supabase-js
[#2454](https://github.com/supabase/supabase-js/pull/2454) (commit
`42b7bbc`), which deep-merges the partial `sortBy` onto the defaults.

## Fix

Give `SortBy` constructor defaults so any partially-specified `SortBy`
fills in the missing field, which is the idiomatic Dart equivalent of
the JS deep-merge and works wherever `SortBy` is constructed:

```dart
const SortBy({this.column = 'name', this.order = 'asc'});
```

Behavior:

- `SortBy(column: 'updated_at')` → `{column: 'updated_at', order:
'asc'}`
- `SortBy(order: 'desc')` → `{column: 'name', order: 'desc'}`
- `list()` with no options → `{column: 'name', order: 'asc'}`
(unchanged)

No breaking change for callers passing a complete `SortBy`.

## Tests

Added a `list sortBy defaults` group in `client_test.dart` (using the
in-memory `CustomHttpClient` to inspect the request body) covering
partial column, partial order, no options, and complete sortBy.

Closes SDK-1089

3 of 3 new or added lines in 1 file covered. (100.0%)

1014 of 1191 relevant lines covered (85.14%)

2.91 hits per line