GrottoCenter / grottocenter-api / 28387141717

87%

develop: 91%

Build Type

Pull #1708

github

Committed by ClemRz

Commit Message

fix(import): address code review findings on async CSV import

- Add atomic test-and-set guard in checkBatchCompletion to prevent
  duplicate notifications when concurrent completion-check jobs fire
- Add error handling around generateAndUploadReports in aggregateBatch
  so batch transitions to 'failed' instead of staying stuck at 'active'
- Push remaining unprocessed rows as failures when outer catch fires
  in processOneChunk to avoid silent row loss
- Remove TOKEN_SALT hardcoded fallback in test-async-import.sh
- Remove CODE_REVIEW.md (does not belong in version control)
- Add 'aggregating' status to TJobBatch model and Swagger spec

Pull Request Pull Request #1708: feat(import): add async CSV import queue with job status endpoint

Coverage Stats

4958 of 5987 branches covered (82.81%)

Branch coverage included in aggregate %.

197 of 307 new or added lines in 8 files covered. (64.17%)

42 existing lines in 2 files now uncovered.

9240 of 10353 relevant lines covered (89.25%)

129.2 hits per line