kubevirt / hyperconverged-cluster-operator / 28383595252

81%

push

github

Fix the flaky imageStream functional test (#4367)

* Fix the flaky imageStream functional test

The imageStream handler checks for the EnableCommonBootImageImport field
with the default value of "false", while the actual default value should
be "true". In production, This is not so bad because the API server will
set it to the deafult value pretty fast.

But when running the imageStream test after the default test, where the
whole spec is deleted, HCO removes the imageStreams, and they are not
recovered on time for the imageStream test.

Fixing the issue by fixing the original bug in the production code, to
set the right default value when reading the EnableCommonBootImageImport
field in the imageStream handler.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* avoid fake compilation error of the func-tests

In some environments, the helper functions in the
tests/func-tests/debugFuncs_test.go file, are not recognized in a
non go test file, like tests/func-tests/hyperconverged.go, because of
the "_test.go" in its file name.

Fixing by renaming to "debugFuncs.go"

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

10981 of 13538 relevant lines covered (81.11%)

2.18 hits per line