dcdpr / jp / 28380998841

69%

Build Type

push

github

Committed by web-flow

Commit Message

feat(cli, term): Show conversation attachments in `jp conversation show` (#813)

`jp conversation show` now lists the attachments associated with a
conversation under an "Attachments" field. Each attachment renders as
`scheme (description): url` when the URL carries a `description` query
parameter, and as the bare URL otherwise. The JSON output serializes
each attachment as an object with `scheme`, `description`, and `url`
fields.

To support list-valued fields in the details view, `jp_term::table`
gains three new types: `DetailRow`, `DetailValue`, and `DetailItem`.
`DetailRow` replaces the raw `comfy_table::Row` type throughout
`print_details`, `details`, `details_markdown`, and `details_json`. A
`DetailValue::List` renders as a bulleted block in the pretty terminal
view, expands to one row per item in the pipe-delimited markdown view,
and becomes a JSON array in the JSON views. The `DetailItem` type lets
the text and JSON representations differ so an attachment can read
naturally in the terminal while still being structured in JSON.

`DetailsFmt` in `jp_cli` gains an `attachments` field and a
`with_attachments` builder method, and the `attachment_detail_item`
helper in `jp_cli::format` constructs the right `DetailItem` from any
attachment URL.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

100 of 182 new or added lines in 7 files covered. (54.95%)

7 existing lines in 2 files now uncovered.

37040 of 55035 relevant lines covered (67.3%)

408.55 hits per line